Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-8541: ProtoValue get_unchecked and visit API #279

Merged
merged 74 commits into from
Sep 20, 2024
Merged

RSDK-8541: ProtoValue get_unchecked and visit API #279

merged 74 commits into from
Sep 20, 2024
+801 −324

Commits on Jul 23, 2024

  1. update paths to cpp files

    @lia-viam
    lia-viam committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cdbd2e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk

    @lia-viam
    lia-viam committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    764cf2f View commit details
    Browse the repository at this point in the history

  2. introduce proof of concept type erasure proto type

    @lia-viam
    lia-viam committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ce05487 View commit details
    Browse the repository at this point in the history

  3. add documentation and tests

    @lia-viam
    lia-viam committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3a24f90 View commit details
    Browse the repository at this point in the history

  4. nolint recursion

    @lia-viam
    lia-viam committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f72ebc1 View commit details
    Browse the repository at this point in the history

  5. make ctor helper an IILE and move the nolint

    @lia-viam
    lia-viam committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0759604 View commit details
    Browse the repository at this point in the history

  6. double nolint

    @lia-viam
    lia-viam committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a01ed14 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. add template keyword for pmf

    @lia-viam
    lia-viam committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7a41fa9 View commit details
    Browse the repository at this point in the history

  2. add helpers to simplify test case invocation

    @lia-viam
    lia-viam committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b834098 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. introduce coexisting pointer based converters

    @lia-viam
    lia-viam committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    981becb View commit details
    Browse the repository at this point in the history

  2. unfriend to_proto_value and remove model value version

    @lia-viam
    lia-viam committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4ae83d9 View commit details
    Browse the repository at this point in the history

  3. ABI insulate proto value

    @lia-viam
    lia-viam committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f391a30 View commit details
    Browse the repository at this point in the history

  4. add and test is_a and use static_cast instead of reinterpret_cast

    @lia-viam
    lia-viam committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    79a4c4d View commit details
    Browse the repository at this point in the history

  5. test copy construction and casting

    @lia-viam
    lia-viam committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    afcdae7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. add holder class and test more copy and move and null

    @lia-viam
    lia-viam committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ada9e37 View commit details
    Browse the repository at this point in the history

  2. add missing namespace

    @lia-viam
    lia-viam committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    19159fe View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk

    @lia-viam
    lia-viam committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    07b82ae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feature/type-erase-proto

    @lia-viam
    lia-viam committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    41bd481 View commit details
    Browse the repository at this point in the history

  5. remove unneeded forward decl

    @lia-viam
    lia-viam committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4c8e592 View commit details
    Browse the repository at this point in the history

  6. update comments

    @lia-viam
    lia-viam committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9705aa2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. use local stack storage for all types and test new move semantics

    @lia-viam
    lia-viam committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0e009aa View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. move small_size and remove unneeded default

    @lia-viam
    lia-viam committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8ab5d96 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/type-erase-proto

    @lia-viam
    lia-viam committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    184f11f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. add struct_to_map and map_to_struct

    @lia-viam
    lia-viam committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a2b751a View commit details
    Browse the repository at this point in the history

  2. use non ptr version

    @lia-viam
    lia-viam committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4e3d985 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. construct with move or rvalue

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5b31f86 View commit details
    Browse the repository at this point in the history

  2. move list value

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2483377 View commit details
    Browse the repository at this point in the history

  3. rename to vtable_t and remove noexcept in function pointers

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    26d7cc7 View commit details
    Browse the repository at this point in the history

  4. s/model_t/model/g

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    03bc715 View commit details
    Browse the repository at this point in the history

  5. s/storage_t/storage/g

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b3e2f09 View commit details
    Browse the repository at this point in the history

  6. remove _value in to_proto/from_proto

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1f45217 View commit details
    Browse the repository at this point in the history

  7. move almost all function defs to source file

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c600450 View commit details
    Browse the repository at this point in the history

  8. update comments, add static_assert, and use aligned_storage_t

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    dfa7575 View commit details
    Browse the repository at this point in the history

  9. revert kind_t change

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1f07ecc View commit details
    Browse the repository at this point in the history

  10. update kind_t comment

    @lia-viam
    lia-viam committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a333406 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. document type trait

    @lia-viam
    lia-viam committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    47bdd17 View commit details
    Browse the repository at this point in the history

  2. rename ProtoT to ProtoValue

    @lia-viam
    lia-viam committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b0b0e15 View commit details
    Browse the repository at this point in the history

  3. use impl type trait for noexcept

    @lia-viam
    lia-viam committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    875d968 View commit details
    Browse the repository at this point in the history

  4. rename attrmap to protostruct

    @lia-viam
    lia-viam committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4b01a12 View commit details
    Browse the repository at this point in the history

  5. add doxygen comments

    @lia-viam
    lia-viam committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ed70190 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. use aligned_union_t for local storage and change static_asserts

    @lia-viam
    lia-viam committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    2a8cb3a View commit details
    Browse the repository at this point in the history

  2. revert impl-ing kind_t and add doc comment

    @lia-viam
    lia-viam committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    51e2b9a View commit details
    Browse the repository at this point in the history

  3. rename files to proto_value

    @lia-viam
    lia-viam committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7ca50e6 View commit details
    Browse the repository at this point in the history

  4. silence recursion linting

    @lia-viam
    lia-viam committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    83de916 View commit details
    Browse the repository at this point in the history

  5. add another nolint

    @lia-viam
    lia-viam committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1516e81 View commit details
    Browse the repository at this point in the history

  6. rename member var

    @lia-viam
    lia-viam committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    b659c76 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk into feat… 

    …ure/type-erase-proto
    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c549e8d View commit details
    Browse the repository at this point in the history

  2. fix typo in move_may_throw

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d5dc9cb View commit details
    Browse the repository at this point in the history

  3. rename impl namespace to detail

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fb48286 View commit details
    Browse the repository at this point in the history

  4. rename dyn_cast to member get

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    50338ab View commit details
    Browse the repository at this point in the history

  5. rename namespace to fit pattern

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    955eae4 View commit details
    Browse the repository at this point in the history

  6. add is_null

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cbcdc4e View commit details
    Browse the repository at this point in the history

  7. static_assert nothrow dtor

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fcf88ac View commit details
    Browse the repository at this point in the history

  8. static_assert size and alignment match

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    896480b View commit details
    Browse the repository at this point in the history

  9. only compile proto_types.cpp into tests

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0536359 View commit details
    Browse the repository at this point in the history

  10. add and test unchecked access

    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c3b27d1 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk into feat… 

    …ure/proto-value-visit
    @lia-viam
    lia-viam committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f10ec1f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. move proto_value tests into own file

    @lia-viam
    lia-viam committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e94a94b View commit details
    Browse the repository at this point in the history

  2. make kind_t sfinae-able

    @lia-viam
    lia-viam committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    95be658 View commit details
    Browse the repository at this point in the history

  3. remove unused include

    @lia-viam
    lia-viam committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5bba955 View commit details
    Browse the repository at this point in the history

  4. add and test proto value visit

    @lia-viam
    lia-viam committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e68a3bd View commit details
    Browse the repository at this point in the history

  5. document visit api

    @lia-viam
    lia-viam committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    cb35f2d View commit details
    Browse the repository at this point in the history

  6. change include order

    @lia-viam
    lia-viam committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    57553a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk into feat… 

    …ure/proto-value-visit
    @lia-viam
    lia-viam committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    df74f74 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. code review: change include order

    @lia-viam
    lia-viam committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4b88dcf View commit details
    Browse the repository at this point in the history

  2. code review: change include order

    @lia-viam
    lia-viam committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    682a270 View commit details
    Browse the repository at this point in the history

  3. code review: change include order

    @lia-viam
    lia-viam committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1ab6ae5 View commit details
    Browse the repository at this point in the history

  4. put extern template in header

    @lia-viam
    lia-viam committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4e12704 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:viamrobotics/viam-cpp-sdk into feat… 

    …ure/proto-value-visit
    @lia-viam
    lia-viam committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c6fd7b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'main' into feature/proto-value-visit

    @lia-viam
    lia-viam committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    47b70f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. replace integer types with enums and no longer expose kind_t

    @lia-viam
    lia-viam committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f55d8a7 View commit details
    Browse the repository at this point in the history

  2. remove switch defaults

    @lia-viam
    lia-viam committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3c330eb View commit details
    Browse the repository at this point in the history

  3. alias protolist

    @lia-viam
    lia-viam committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    31116da View commit details
    Browse the repository at this point in the history

  4. use k_ for enum names and add explicit numerical values

    @lia-viam
    lia-viam committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f5e94cf View commit details
    Browse the repository at this point in the history