-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support check persistent-license to remove the mediakeysession #7050
Open
JackPu
wants to merge
13
commits into
video-dev:master
Choose a base branch
from
JackPu:jackpu/fix_mks_remove_not_resolve
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: support check persistent-license to remove the mediakeysession #7050
JackPu
wants to merge
13
commits into
video-dev:master
from
JackPu:jackpu/fix_mks_remove_not_resolve
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPu
commented
Feb 26, 2025
I will fix the unit tests later |
robwalch
requested changes
Mar 4, 2025
robwalch
previously approved these changes
Mar 5, 2025
robwalch
reviewed
Mar 11, 2025
Waiting for a response to the comments above.
@robwalch Do you have some other ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
It will check if the session type is
persistent-license
and then make the decision to executemediakeySession.remove
.Why is this Pull Request needed?
I mentioned the issue here: #6806
We have found the issue on the Samsung and Comcast platforms. It seems we cannot resolve the method mediaKeySession.remove(). Because we cannot close the media session, it will cause the next time session request. It will throw an error like this
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist