Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support check persistent-license to remove the mediakeysession #7050

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

JackPu
Copy link
Contributor

@JackPu JackPu commented Feb 26, 2025

This PR will...

It will check if the session type is persistent-license and then make the decision to execute mediakeySession.remove.

Why is this Pull Request needed?

I mentioned the issue here: #6806

We have found the issue on the Samsung and Comcast platforms. It seems we cannot resolve the method mediaKeySession.remove(). Because we cannot close the media session, it will cause the next time session request. It will throw an error like this

TypeError-Failed to execute 'generateRequest' on 'MediaKeySession': Request generation failed. . (99999)

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@JackPu
Copy link
Contributor Author

JackPu commented Feb 26, 2025

I will fix the unit tests later

@JackPu JackPu requested a review from robwalch March 4, 2025 08:13
robwalch
robwalch previously approved these changes Mar 5, 2025
@robwalch robwalch requested a review from cjpillsbury March 5, 2025 23:42
@robwalch robwalch added this to the 1.6.0 milestone Mar 5, 2025
@robwalch robwalch dismissed their stale review March 14, 2025 22:24

Waiting for a response to the comments above.

@robwalch robwalch removed this from the 1.6.0 milestone Mar 14, 2025
@JackPu JackPu requested a review from robwalch March 19, 2025 04:30
@JackPu
Copy link
Contributor Author

JackPu commented Mar 21, 2025

@robwalch Do you have some other ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants