Various warning fixes#51
Merged
Merged
Conversation
It only makes sense in a header file.
When returning by value this has no effect.
It doesn't make sense to request a channel for a negative index.
Fixes the comparison of integers of different signs warning, as we already checked index to be bigger than -1.
Fixes invalid UTF-8 in comment warning.
Fixes comparison of integers of different signs warning.
These can never be negative and fixes a mixed-sign comparison later.
The added parameter is actually unused so we can cleanly override the base class Configure. Also mark Reset and Refresh as override.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We inherit the base class Configure method, however calling that one would result in our class to not actually be configured properly. We can not just override the base Configure as we require different arguments, so instead mark it as private so it can not be called.
We override it as private method so that API users can't accidentally use it and end up with a not properly configure object.
Fixes invalid UTF-8 in comment warning.
Fixes suggest braces around initialization of subobject warning.
These were only ever written but never read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.