Header cleanups#65
Merged
Merged
Conversation
ePirat
commented
Nov 10, 2025
ePirat
commented
Collaborator
- Use header include guards consistently in our public headers
- Do not use reserved identifiers for header include guard defines
- Rename DirectSpeakerGainCalc to DirectSpeakersGainCalc to be consistent with the actual class name
Collaborator
|
👍 |
Only the generic one is needed in the public interface here, so do not include the specific ones.
Prevents possible clashes and also ensures we do not use preprocessor defines with a leading underscore as those are reserved for the standard library implementation details.
This aligns it with the class name and the comments in the files.
ePirat
force-pushed
the
epirat-includes-namespace
branch
from
5022c79 to
61ae2cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.