Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👍 Refine argument types for buffer-function #196

Merged
merged 1 commit into from
May 11, 2023
Merged

👍 Refine argument types for buffer-function #196

merged 1 commit into from
May 11, 2023

Conversation

Milly
Copy link
Contributor

@Milly Milly commented May 10, 2023 •
edited
Loading

Refs #44

Added following types for arguments of buffer-function.

export type BufExistsArg = string | number;
export type BufNameArg = string | number;
export type BufLnumArg = "$" | number;

It makes the meaning of the argument types easier to understand.

@Milly Milly requested a review from lambdalisue May 10, 2023 11:46
lambdalisue
lambdalisue approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lambdalisue lambdalisue merged commit a930596 into main May 11, 2023
@lambdalisue lambdalisue deleted the refine-buffer-function branch May 11, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shougo Shougo Shougo approved these changes

@lambdalisue lambdalisue lambdalisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Milly @Shougo @lambdalisue