Update develop.{txt,jax} #2069
Open
Update develop.{txt,jax} #2069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mityu
approved these changes
May 10, 2025
tsuyoshicho
reviewed
May 10, 2025
| @@ -232,15 +232,15 @@ sound.c と sign.c は、配布された .clang-format ファイルに従って | |||
| < | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
もしかしたら、ある種の typo なのかもしれませんが、空行が 2 -> 1 になっているので、ここを削除する必要がありますね
なんとなくですが、< マーカーだけの行も空行だよねと、扱いを変えた気がしないでもないです(あるいはそれで見間違えたのかもですが)
| @@ -261,113 +261,77 @@ OK: > | |||
| < | |||
|
|
|||
|
|
|||
| 間違い: > | ||
| int is_valid_line_number(unsigned long lnum); | ||
| < | ||
|
|
| @@ -414,7 +378,6 @@ OK: > | |||
| while (buf != NULL && !got_int) | |||
| < | |||
|
|
|||
|
|
|||
Comment on lines
+326
to
+327
| 説明的な型を使用すること。これらは src/vim.h、src/structs.h などで定義されてい | ||
| る。 |
There was a problem hiding this comment.
Note:
日本語で2つの例を出すのであれば
src/vim.h や src/structs.h など
としたほうがおさまりがいいかもしれません。
ただ、これもOKと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.