-
Notifications
You must be signed in to change notification settings - Fork 64
Added System.AsyncProcess. #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikoto2000
wants to merge
14
commits into
vim-jp:master
Choose a base branch
from
mikoto2000:add-async-process
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2bdd67 to
da0b2af
Compare
0556520 to
e165c1d
Compare
Contributor
|
draft 時は1コミットずつテストOKしないとだめだった、たぶん今は平気 だめだった……再度実行はしました |
tsuyoshicho
reviewed
Dec 3, 2025
Comment on lines
101
to
107
| " v8.2.238 or earlier, job_stop() exit status is 0. | ||
| " See: https://github.com/vim/vim/commit/b3e195cca7b3201b188c1713b64012b1bef4f61f | ||
| if v:version == 802 && !has('patch238') || v:version < 802 | ||
| Assert True(g:exit_code == 0) | ||
| else | ||
| Assert True(g:exit_code != 0) | ||
| endif |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
えっと、パッチされたのは Windows だけな気がするので、Windowsとそれ以外では違う処理にしないとではないかと
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご指摘の通り...
コミット 1e9054b で修正しました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#836 の実装を行っています。
現時点でツッコミどころなど、指摘いただけると幸いです。
TODO:
-cor pwsh or powershell :-Cor cmd.exe :/c)