Stoner stochastic graphing overhaul#37
Open
weshinsley wants to merge 14 commits intomasterfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
===========================================
+ Coverage 98.01% 100.00% +1.98%
===========================================
Files 23 22 -1
Lines 2568 2640 +72
===========================================
+ Hits 2517 2640 +123
+ Misses 51 0 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kgaythorpe
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pretty horrible PR really with a lot of churn to achieve some specific things. It might be best to just review the finished stochastic_file and stochastic_graph files (and maybe read the vignette) - and not treat this as a diff, as it's so messy,
Anywyay - it achieves the following, which kind of had to come in one go, or something else would break...
stochastic_file has a new command
stone_stochastic_make_metawhich makes a meta.csv in the root of the stochastic files (\wpia-hn2.hpc.dide.ic.ac.uk\vimc_stochastics), giving meta-data about the groups, diseases, touchstones, scenarios, outcomes and countries, so we know what we've got at a glance, rather than having to do a nasty trawl.stochastic_explorer (the shiny app) uses the meta file instead of having to do exactly that nasty trawl, which saves about 20 seconds on startup, and makes everything a bit less sluggish generally. Some churn in utils.R with how it finds the info.
stochastic_graph can now produce two graphs at once with the same y-axis scale, in order to compare estimates in different touchstones, or by different modellin groups (keeping all other selections the same) - with the additional possibility of being able to plot the difference (often called impact) between two scenarios. This also was quite a churny update.
stochastic_graph can also plot with age as the x-axis, and filter which years to reduce - as well as plotting by time on the x-axis, and choosing which ages to reduce. Basically this is all flexed up.
All the above is available from the shiny app....
And written up in the vignette.