Skip to content

Add ridgeline chart #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-mears-2 wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Add ridgeline chart #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
b7d5da2
wip
david-mears-2 Dec 11, 2025
dfc6428
Refactor filtes to be computed
david-mears-2 Dec 11, 2025
08ff003
Do line filtration at the point of creating line objects, not after
david-mears-2 Dec 12, 2025
28dc9b1
The logic is correct, but updating lines seems to take longer than be…
david-mears-2 Dec 12, 2025
1b3377d
Assign colors to lines
david-mears-2 Dec 12, 2025
c11cbce
Refactor colors into composable
david-mears-2 Dec 12, 2025
78464ad
Use color store instead of composable
david-mears-2 Dec 12, 2025
4efd85c
Expose color map so that we can have a legend; reset color maps after…
david-mears-2 Dec 12, 2025
3ac6807
Refactor
david-mears-2 Dec 15, 2025
c7e1add
Add activity type options as static (but auto-generated during pre-bu…
david-mears-2 Dec 15, 2025
abda159
Refactor; ensure only one re-calculation of ridgeLines per update of …
david-mears-2 Dec 15, 2025
7d84d8f
Update skadi-chart version and tell user if no data available
david-mears-2 Dec 15, 2025
209a07a
Update tests
david-mears-2 Dec 15, 2025
a72548b
Unit-test color store
david-mears-2 Dec 15, 2025
41ae249
Unit-test some utils
david-mears-2 Dec 15, 2025
8cfa9f9
Test color mapping in RidgelinePlot component
david-mears-2 Dec 15, 2025
30308d5
Increase test timeout
david-mears-2 Dec 15, 2025
bd18861
Update appStore unit tests
david-mears-2 Dec 15, 2025
88e2927
Update RidgelinePlot component test
david-mears-2 Dec 15, 2025
f863feb
Relayout error messages
david-mears-2 Dec 15, 2025
aaa056f
Remove unneeded Math.max
david-mears-2 Dec 16, 2025
f258ddc
Small respellings
david-mears-2 Dec 16, 2025
b78c8ce
Fix line mappig bracketing
david-mears-2 Dec 16, 2025
6a4a843
Refactor color store: assign all colors up-front, and use different p…
david-mears-2 Dec 16, 2025
69582b4
Condition grid lines on whether there is an x-categorical axis
david-mears-2 Dec 16, 2025
9038c6a
Refactor generateOptions script
david-mears-2 Dec 17, 2025
2ce404f
Refactor color store
david-mears-2 Dec 17, 2025
c1ba7d2
Make things a little terser
david-mears-2 Dec 17, 2025
5778450
Update comment
david-mears-2 Dec 18, 2025
a792418
Small tidies from review comments
david-mears-2 Dec 22, 2025
16d1166
Refactor color store: don't assign colors up-front, but on a need-to-…
david-mears-2 Dec 22, 2025
b740d09
Extract ridgeline construction to composable
david-mears-2 Dec 22, 2025
d408ab0
Make useHistogramLines know less about data parsing, color setting
david-mears-2 Dec 22, 2025
5d29241
Fix some types
david-mears-2 Dec 23, 2025
fc10c96
Put the category label function as an argument to useHistogramLines c…
david-mears-2 Dec 23, 2025
eb9c05e
Rename 'x/y categorical axis' to 'column', 'row'
david-mears-2 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,5 @@ npm run lint
1. From the same packet, download `who_sub_regions.csv` (under 'Other files'). This provides the mapping from countries to subregions.
1. Delete contents of `public/data/csv`.
1. Unzip the dataviz.zip folder into `public/data/csv`, and move `who_sub_regions.csv` there too.
1. Ensure your current Node version is >= 24.
1. Run `./scripts/convert-csv-files-to-json.sh <packet-id>` replacing the packet id argument
Loading
Loading