Skip to content

Conversation

@pratikunterwegs
Copy link
Contributor

@pratikunterwegs pratikunterwegs commented Dec 9, 2025

This PR makes initial changes to the template.

To do:

  • Check the package title (must be title case, but please check content), see DESCRIPTION;
  • Check the package description field, and check that the reference is suitable, and suggest others if needed, see DESCRIPTION and also README.Rmd (the plain markdown will render automatically via an action);
  • Check and suggest changes to the author list.
  • Any other issues: license file, pkg maintainer (I am currently listed), pkg author contact details (I have deliberately omitted these for now).

Everything can be changed later, so no need to consider any text final.

This branch will auto-delete once this PR is merged. I think a develop/main branching workflow is sufficient for initial package development. We can discuss branch naming and issue creation once there's a minimal working example.

If merging directly on approval, please prefer a rebase to keep a linear commit history.

@pratikunterwegs pratikunterwegs marked this pull request as ready for review December 9, 2025 11:56
@pratikunterwegs pratikunterwegs self-assigned this Dec 9, 2025
Copy link

@zegibney zegibney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Pratik! I've added some initial thoughts/ comments but would wait and see what Xiang/Katy have to say too before making any substantial changes :)

Copy link

@xiangli313 xiangli313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pratikunterwegs and @zegibney. The PR looks great to me. I would agree with Zoe's comments in general.

@pratikunterwegs
Copy link
Contributor Author

There's a MacOS workflow failing for non-package reasons (it can't install something upstream) - so this should be safe to review. I'll wait a bit before re-running the failing workflow, and merge once it passes.

@pratikunterwegs pratikunterwegs merged commit 40f7da3 into main Dec 11, 2025
@pratikunterwegs pratikunterwegs deleted the develop branch December 11, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants