-
Notifications
You must be signed in to change notification settings - Fork 0
Initial package infrastructure #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zegibney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Pratik! I've added some initial thoughts/ comments but would wait and see what Xiang/Katy have to say too before making any substantial changes :)
xiangli313
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pratikunterwegs and @zegibney. The PR looks great to me. I would agree with Zoe's comments in general.
|
There's a MacOS workflow failing for non-package reasons (it can't install something upstream) - so this should be safe to review. I'll wait a bit before re-running the failing workflow, and merge once it passes. |
This PR makes initial changes to the template.
To do:
DESCRIPTION;DESCRIPTIONand alsoREADME.Rmd(the plain markdown will render automatically via an action);Everything can be changed later, so no need to consider any text final.
This branch will auto-delete once this PR is merged. I think a
develop/mainbranching workflow is sufficient for initial package development. We can discuss branch naming and issue creation once there's a minimal working example.If merging directly on approval, please prefer a rebase to keep a linear commit history.