fix: use default fetch mode for PHP8 PDO implementation #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a copy of the changes from PR#15 (0e864b2), making the two versions of `FakePdo` behave the same WRT respecting `->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, *)`. Made sure to add an appropriate test.
MelechMizrachi
approved these changes
Jun 27, 2024
|
Just need to fix the conflict since I merged #46 first. |
…ngine into kesills-php8-fetch-mode The new test conflicted with another one being added. I accepted the incoming changes, then just copy and pasted this branch's test above it.
|
@MelechMizrachi Of course, thanks for such a quick turnaround time! The conflict is resolved. 😄 |
MelechMizrachi
approved these changes
Jun 27, 2024
|
Absolutely, @Kenneth-Sills! Thanks again for the contribution :) |
|
Added in release https://github.com/vimeo/php-mysql-engine/releases/tag/0.7.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of the changes from #15 (0e864b2), making the two versions of
FakePdobehave the same WRT respecting->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, *).Made sure to add an appropriate test.