Fix PHP 7 return type checks for functions without docblocks

vimeo · Dec 4, 2016 · d951e1d · d951e1d
1 parent a1acbfe
commit d951e1d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/src/Psalm/Checker/FunctionChecker.php b/src/Psalm/Checker/FunctionChecker.php
@@ -209,6 +209,18 @@ protected function registerFunction(PhpParser\Node\Stmt\Function_ $function, $fi
 
         $this->suppressed_issues = [];
 
+        if ($function->returnType) {
+            $return_type = Type::parseString(
+                is_string($function->returnType)
+                    ? $function->returnType
+                    : ClassLikeChecker::getFQCLNFromNameObject(
+                        $function->returnType,
+                        $this->namespace,
+                        $this->getAliasedClasses()
+                    )
+            );
+        }
+
         $doc_comment = $function->getDocComment();
 
         if ($doc_comment) {
@@ -239,18 +251,6 @@ protected function registerFunction(PhpParser\Node\Stmt\Function_ $function, $fi
 
                 $this->suppressed_issues = $docblock_info->suppress;
 
-                if ($function->returnType) {
-                    $return_type = Type::parseString(
-                        is_string($function->returnType)
-                            ? $function->returnType
-                            : ClassLikeChecker::getFQCLNFromNameObject(
-                                $function->returnType,
-                                $this->namespace,
-                                $this->getAliasedClasses()
-                            )
-                    );
-                }
-
                 if ($config->use_docblock_types) {
                     if ($docblock_info->return_type) {
                         $return_type =

diff --git a/src/Psalm/Checker/FunctionLikeChecker.php b/src/Psalm/Checker/FunctionLikeChecker.php
@@ -494,7 +494,7 @@ public function checkReturnTypes($update_docblock = false)
 
             if (IssueBuffer::accepts(
                 new InvalidReturnType(
-                    'No return type was found for method ' . $cased_method_id .
+                    'No return statements were found for method ' . $cased_method_id .
                         ' but return type \'' . $declared_return_type . '\' was expected',
                     new CodeLocation($this, $this->function, true)
                 )