IsRebuildAll and Form showing monthly totals #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
January 21, 2016 18:51
…h, add some tests based on the problems encountered
…t will have been acted on
| <Compile Include="Properties\AssemblyInfo.cs" /> | ||
| <Compile Include="UI\LongExtensions.cs" /> | ||
| <Compile Include="UI\Time.cs" /> | ||
| <Compile Include="UI\TimePresenter.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Include="cedd.snk" /> | ||
| <None Include="key.pfx" /> |
There was a problem hiding this comment.
My memory of signing is a bit fuzzy, but is the key.pfx still needed?
There was a problem hiding this comment.
It depends. The snk is used for strong-naming, which uses a key pair to uniquely identify an assembly. The pfx is for code signing, which is a similar process but one that is intended to prevent malicious tampering with assemblies that are distributed publicly. Using both on an assembly both strong-names AND signs it.
It would probably be best to compile and release it using your original pfx, but I can't do this as I don't have the password.
Also removed the VS upgrade log, which seems unnecessary.
The solution now builds in vs 2017
Settings is no longer a static class in order to be able to create it with a WritableSettingsStore to persist data. Instead, it has a static instance.
Broke out the output window code to separate class. Also removed the IntExtension which can be replaced by a standard string constructor.
Add ability to change output path
It switches to Async initialization to improve load time performance. Probably more things could be done before switching to the main ui thread, but its still an improvment. I haven't got the tests to run when opening the solution in vs 2019 yet
The nunit 2 tests wouldn't run in vs 2019, despite doing all the things you are supposed to do. Upgrading to 3 is probably a good idea anyway though
The problem happend because the solution name was null. I have made sure that this can't happen, and an empty string is now used instead. I have also found the reason why the solution name was null and fixed that. The Opened event doesn't fire when a solution is opened when starting vs 2019, as I think we only connect to the events after the solution is already open. To get round this I call the event manually during initialize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI Daniel
This pull request introduces a new variable "IsRebuildAll", which is output to the buildmonitor window and saved with the JSON.
It also includes the changes from the previous pull request, which were to show a form with a breakdown of total compile time by month and by solution.
Cheers
Cedd