Fix Python version mismatch in setup.py#1025
Merged
Merged
Conversation
Align setup.py with pyproject.toml and project documentation by lowering the required Python version to >=3.10. This fixes wheel compilation failures on Python 3.10 environments.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates packaging metadata so setup.py matches the project’s declared minimum supported Python version (>=3.10) in pyproject.toml, preventing wheels from advertising compatibility with Python versions they won’t install on.
Changes:
- Set
python_requiresinsetup.pyfrom>=3.12to>=3.10to align withpyproject.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings DefTruth,
Thanks for your wonderful work.
pyproject.toml and the project documentation state that Python >=3.10 is supported. However, setup.py hardcodes python_requires=">=3.12", which allows things like building cp310 wheels that won't install in cp310 environments.
This trivial PR updates setup.py to match pyproject.toml.
Best regards,
FNG