Fix [command] : update command initialisation with correct extension-less name#25
Open
Albireo-B wants to merge 1 commit into
Open
Fix [command] : update command initialisation with correct extension-less name#25Albireo-B wants to merge 1 commit into
Albireo-B wants to merge 1 commit into
Annotations
9 errors and 13 warnings
|
Maven
❌ Failed to create checks using the provided token. (HttpError: Resource not accessible by integration)
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalSubmit.java#L152
The FileInputStream and FileOutputStream classes contains a finalizer method which will cause garbage
collection pauses.
See [JDK-8080225](https://bugs.openjdk.org/browse/JDK-8080225) for details.
The FileReader and FileWriter constructors instantiate FileInputStream and FileOutputStream,
again causing garbage collection issues while finalizer methods are called.
* Use `Files.newInputStream(Paths.get(fileName))` instead of `new FileInputStream(fileName)`.
* Use `Files.newOutputStream(Paths.get(fileName))` instead of `new FileOutputStream(fileName)`.
* Use `Files.newBufferedReader(Paths.get(fileName))` instead of `new FileReader(fileName)`.
* Use `Files.newBufferedWriter(Paths.get(fileName))` instead of `new FileWriter(fileName)`.
Please note, that the `java.nio` API does not throw a `FileNotFoundException` anymore, instead
it throws a `NoSuchFileException`. If your code dealt explicitly with a `FileNotFoundException`,
then this needs to be adjusted. Both exceptions are subclasses of `IOException`, so catching
that one covers both.
AvoidFileStream (Priority: 1, Ruleset: Performance)
https://docs.pmd-code.org/snapshot/pmd_rules_java_performance.html#avoidfilestream
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalSubmit.java#L142
The FileInputStream and FileOutputStream classes contains a finalizer method which will cause garbage
collection pauses.
See [JDK-8080225](https://bugs.openjdk.org/browse/JDK-8080225) for details.
The FileReader and FileWriter constructors instantiate FileInputStream and FileOutputStream,
again causing garbage collection issues while finalizer methods are called.
* Use `Files.newInputStream(Paths.get(fileName))` instead of `new FileInputStream(fileName)`.
* Use `Files.newOutputStream(Paths.get(fileName))` instead of `new FileOutputStream(fileName)`.
* Use `Files.newBufferedReader(Paths.get(fileName))` instead of `new FileReader(fileName)`.
* Use `Files.newBufferedWriter(Paths.get(fileName))` instead of `new FileWriter(fileName)`.
Please note, that the `java.nio` API does not throw a `FileNotFoundException` anymore, instead
it throws a `NoSuchFileException`. If your code dealt explicitly with a `FileNotFoundException`,
then this needs to be adjusted. Both exceptions are subclasses of `IOException`, so catching
that one covers both.
AvoidFileStream (Priority: 1, Ruleset: Performance)
https://docs.pmd-code.org/snapshot/pmd_rules_java_performance.html#avoidfilestream
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalSubmit.java#L67
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalOutputParser.java#L49
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalMonitor.java#L49
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalMonitor.java#L47
Reports classes that may be made final because they cannot be extended from outside
their compilation unit anyway. This is because all their constructors are private,
so a subclass could not call the super constructor.
ClassWithOnlyPrivateConstructorsShouldBeFinal (Priority: 1, Ruleset: Design)
https://docs.pmd-code.org/snapshot/pmd_rules_java_design.html#classwithonlyprivateconstructorsshouldbefinal
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalConfiguration.java#L46
Configurable naming conventions for field declarations. This rule reports variable declarations
which do not match the regex that applies to their specific kind ---e.g. constants (static final),
enum constant, final field. Each regex can be configured through properties.
By default this rule uses the standard Java naming convention (Camel case), and uses the ALL_UPPER
convention for constants and enum constants.
FieldNamingConventions (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#fieldnamingconventions
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalConfiguration.java#L44
Reports classes that may be made final because they cannot be extended from outside
their compilation unit anyway. This is because all their constructors are private,
so a subclass could not call the super constructor.
ClassWithOnlyPrivateConstructorsShouldBeFinal (Priority: 1, Ruleset: Design)
https://docs.pmd-code.org/snapshot/pmd_rules_java_design.html#classwithonlyprivateconstructorsshouldbefinal
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-java@v3, mikepenz/action-junit-report@v3, pmd/pmd-github-action@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Maven
⚠️ This usually indicates insufficient permissions. More details: https://github.com/mikepenz/action-junit-report/issues/23
|
|
Maven
Cannot build an overlay database because build-mode is set to "undefined" instead of "none". Falling back to creating a normal full database instead.
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalMonitor.java#L84
New objects created within loops should be checked to see if they can created outside them and reused.
AvoidInstantiatingObjectsInLoops (Priority: 3, Ruleset: Performance)
https://docs.pmd-code.org/snapshot/pmd_rules_java_performance.html#avoidinstantiatingobjectsinloops
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalMonitor.java#L75
A local variable assigned only once can be declared final.
LocalVariableCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#localvariablecouldbefinal
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalMonitor.java#L74
A local variable assigned only once can be declared final.
LocalVariableCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#localvariablecouldbefinal
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/execution/LocalMinorStatusServiceGenerator.java#L43
Each non-static class should declare at least one constructor.
Classes with solely static members are ignored, refer to [UseUtilityClassRule](pmd_rules_java_design.html#useutilityclass) to detect those.
AtLeastOneConstructor (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#atleastoneconstructor
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalExecutor.java#L71
In some cases, explicit type arguments in a constructor call for a generic type
may be replaced by diamond type arguments (`<>`), and be inferred by the compiler.
This rule recommends that you use diamond type arguments anywhere possible, since
it avoids duplication of the type arguments, and makes the code more concise and readable.
This rule is useful when upgrading a codebase to Java 1.7, Java 1.8, or Java 9.
The diamond syntax was first introduced in Java 1.7. In Java 8, improvements in Java's
type inference made more type arguments redundant. In Java 9, type arguments inference
was made possible for anonymous class constructors.
UseDiamondOperator (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#usediamondoperator
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalExecutor.java#L62
Reports method and constructor parameters that can be made final because they are never reassigned within the body of the method.
This rule ignores unused parameters so as not to overlap with the rule {% rule java/bestpractices/UnusedFormalParameter %}.
It will also ignore the parameters of abstract methods.
MethodArgumentCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#methodargumentcouldbefinal
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalExecutor.java#L52
Each non-static class should declare at least one constructor.
Classes with solely static members are ignored, refer to [UseUtilityClassRule](pmd_rules_java_design.html#useutilityclass) to detect those.
AtLeastOneConstructor (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#atleastoneconstructor
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalConstants.java#L46
Fields, formal arguments, or local variable names that are too long can make the code difficult to follow.
LongVariable (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#longvariable
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalConstants.java#L42
A class is a utility class, if and only if it fulfills ALL the following criteria:
* ALL member functions, member variables, nested classes, and initializers are static.
* The class has at least one member function, member variable, or nested class that is not private.
* The class is a concrete class (neither abstract nor an interface).
* The class has no superclasses and implements no interfaces.
* The class has no main method.
Utility classes should not be instantiable. Make sure that the only constructor is a
private no-args constructor to enforce this.
(Note, that this rule was known before PMD 5.1.0 as UseSingleton).
UseUtilityClass (Priority: 3, Ruleset: Design)
https://docs.pmd-code.org/snapshot/pmd_rules_java_design.html#useutilityclass
|
|
Review Code:
src/main/java/fr/insalyon/creatis/gasw/plugin/executor/local/LocalConfiguration.java#L61
A local variable assigned only once can be declared final.
LocalVariableCouldBeFinal (Priority: 3, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#localvariablecouldbefinal
|
background
wait
wait-all
cancel
parallel
Loading