Reconnect after failure#2
Open
billstron wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to better recover from master node failures. It introduces the following:
commandTimeoutthat will error any commands that take longer than the setting. This ensures that we do not hang for an infinite amount of time.getSlotsmethod so that an accidental call to a failing node does not result in a hung system. The timeout from (1) could not be used without a more disruptive rewrite of the package.subscribeAllwhen thesubscribeClientis pointed at the failing node. This is done after the failing node is removed from the list so that it doesn't get used again.closes virtual-peaker/product-vp#3408