-
Notifications
You must be signed in to change notification settings - Fork 12
feat: β [Issue 7] Explore page #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
apoorv-on-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work overall the result looks fantastic! A few things I would also mention in my review, but do note -
- The section mentioned contains categories. Now if you see, instead of the icons and the text, the design philosophy is the same. It might be better to render this from JS, just as you've done with the videos, using a list of objects containing icon names and text.
- Get rid of all the comments. It's not a good idea to raise pull requests with commented code. Comments should only be for essential bits of information describing the code or its functionality.
- Why don't you use the CDNs available for the owl carousel given here - https://cdnjs.com/libraries/OwlCarousel2 - You can take the minified links and add them in the headers of the explore.html file.
- Remove the screenshot directory. There's no need for that.
unnikrishnan2002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would request a couple of changes -
- Don't edit the
PULL_REQUEST_TEMPLATE.mdfile. You just have to edit the template which will appear in you PR comment while making a PR and not edit the file itself. - Maintain the formatting of CSS code. Keep a 4 space gap when you write properties, put the properties in alphabetical order, end the closing bracket in a new line, keep 1 space after each property block
- Maintain the formatting of js file as well. currently its not uniform for the whole file. Keep a space of 4 whenever you have to nest elements inside the block
unnikrishnan2002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the commented part from the explore.css file
removed commented part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

π οΈ Fixes Issue
π¨βπ» Changes proposed
βοΈ Check List (Check all the applicable boxes)
π Note to reviewers
π· Screenshots