feat(widgets): Simple GeolocateWidget#9488
Merged
Conversation
felixpalmer
reviewed
Mar 12, 2025
| * Supports comma- or semicolon-separated values. | ||
| * Heuristically determines which value is longitude and which is latitude. | ||
| */ | ||
| function parseCoordinates(input) { |
Collaborator
There was a problem hiding this comment.
The coordinate parsing functions could use some unit tests
felixpalmer
approved these changes
Mar 12, 2025
| } | ||
| onKeyPress={this.handleKeyPress} | ||
| /> | ||
| <button onClick={this.handleSubmit}>Go</button> |
Collaborator
There was a problem hiding this comment.
Could this button be styled the same as the other widgets?
ibgreen
force-pushed
the
ib/geolocate-widget
branch
from
38c4118 to
a1695aa
Compare
chrisgervang
approved these changes
Mar 28, 2025
Collaborator
chrisgervang
left a comment
chrisgervang
left a comment
There was a problem hiding this comment.
Stamping so we can experimentally merge this in. To graduate let's take a pass on design improvement, theming, and unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Background
Change List