Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release) CHANGELOG now always contains v prefix #9538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisgervang
Copy link
Collaborator

Background

I found a bug in the github release script while using it in hubble. This script is currently disabled in deck's release action, but if we choose to re-enable it, the script would currently fail.

Change List

  • remove broken regex

@coveralls
Copy link

Coverage Status

coverage: 91.627%. remained the same
when pulling 17291c6 on chr/fix-github-release
into 21dcaee on master.

@chrisgervang
Copy link
Collaborator Author

Oh, should this script just be removed all together? dev-tools seems to do the same thing, and running it broke the release script in hubble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants