Code cleanup for movie, render, runner #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pillow has removed the fromstring() function. It recommends using frombytes() instead. Put the fix in a try so it should continue to work with older versions
update from head
Added sfgen import to make it work. Moved snowflake defaults to snowflake.py
Deleted code duplicated in runner.py, render.py, and movie.py
added import ststements for movie, render, and runner
Added argparse import since it's needed in this file (why rely on an import in another imported file?) Snowflake defaults now lives here
Added movie, render, and runner to the py_moduels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant code from engine.py, expanded readme for requirements for 3d pipeline, misc minor code cleanup