fix: handle yarn command fail when root does not exist #18141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Angular sets a path that doesn't exist to root.
https://github.com/angular/angular-cli/blob/ea4a125233c3ad9bc225e365b21a6b5d2d885720/packages/angular/build/src/builders/dev-server/vite-server.ts#L550-L553
That makes
execSync
to fail, because Windows requirescwd
to exist.vite/packages/vite/src/node/server/index.ts
Lines 1046 to 1049 in c1ed8a5
This PR fixes that by using
searchForPackageRoot(root)
forcwd
instead ofroot
. But I'm not sure if we want to support this case.fixes #18136