Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vtgate metrics: Added plan and query type metrics #17727

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 10, 2025

Description

This PR adds classification of query plans based on their execution strategy.
Additionally, this PR introduces a new metrics counter, QueryProcessed, which tracks queries processed at VTGate with labels for Query, Plan, and Tablet type. This metric provides better observability into query distribution and execution patterns

Plan Classification

Query plans are categorized into different types based on their execution behavior:

  • Local – Queries executed locally on VTGate without involving any shard.
  • Passthrough – Queries forwarded to single shard without having any additional processing at VTGate.
  • MultiShard – Queries executed across multiple shards with controlled routing.
  • Lookup – Queries using lookup vindexes to resolve keyspace IDs efficiently and route to specific shards.
  • Scatter – Queries broadcast to all shards.
  • JoinOp – Queries involving join operations across multiple shards, with Join on VTGate.
  • ForeignKey – Queries handling foreign key constraints, such as cascades and validations.
  • Complex – Queries with intricate execution logic requiring VTGate to process results.
  • OnlineDDL – DDLs executed though Online Schema change workflow.
  • DirectDDL – DDLs directly executed on the shards.
  • Transaction – Queries managing transactions, including BEGIN, COMMIT, ROLLBACK, and SAVEPOINT.
  • Topology - Queries that involves accessing Topology Server for Get/Put.

Published Metrics

Sample metrics from VTGate's /metrics path:

# HELP vtgate_query_processed Query processed at vtgate by query, plan, and tablet type
# TYPE vtgate_query_processed counter
vtgate_query_processed{plan="Complex",query="SET",tablet="PRIMARY"} 1
vtgate_query_processed{plan="Local",query="USE",tablet="PRIMARY"} 1
vtgate_query_processed{plan="MultiShard",query="DELETE",tablet="PRIMARY"} 1
vtgate_query_processed{plan="MultiShard",query="UPDATE",tablet="PRIMARY"} 1
vtgate_query_processed{plan="Passthrough",query="SHOW",tablet="PRIMARY"} 1
vtgate_query_processed{plan="Scatter",query="DELETE",tablet="PRIMARY"} 20
vtgate_query_processed{plan="Scatter",query="SELECT",tablet="PRIMARY"} 1
vtgate_query_processed{plan="Transaction",query="ROLLBACK",tablet="PRIMARY"} 1
vtgate_query_processed{plan="Transaction",query="SAVEPOINT",tablet="PRIMARY"} 1

# HELP vtgate_query_routed Query routed from vtgate to vttablet by query, plan, and tablet type
# TYPE vtgate_query_routed counter
vtgate_query_routed{plan="Complex",query="SET",tablet="PRIMARY"} 0
vtgate_query_routed{plan="Local",query="USE",tablet="PRIMARY"} 0
vtgate_query_routed{plan="MultiShard",query="DELETE",tablet="PRIMARY"} 2
vtgate_query_routed{plan="MultiShard",query="UPDATE",tablet="PRIMARY"} 2
vtgate_query_routed{plan="Passthrough",query="SHOW",tablet="PRIMARY"} 1
vtgate_query_routed{plan="Scatter",query="DELETE",tablet="PRIMARY"} 56
vtgate_query_routed{plan="Scatter",query="SELECT",tablet="PRIMARY"} 2
vtgate_query_routed{plan="Transaction",query="ROLLBACK",tablet="PRIMARY"} 0
vtgate_query_routed{plan="Transaction",query="SAVEPOINT",tablet="PRIMARY"} 0

Related Issue(s)

Checklist

Copy link
Contributor

vitess-bot bot commented Feb 10, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 10, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 94.75983% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.96%. Comparing base (000fbbe) to head (aa4c4c7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtgate/engine/plan.go 93.02% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #17727    +/-   ##
========================================
  Coverage   67.95%   67.96%            
========================================
  Files        1586     1586            
  Lines      255208   255373   +165     
========================================
+ Hits       173423   173560   +137     
- Misses      81785    81813    +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 10, 2025
@harshit-gangal harshit-gangal removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Feb 11, 2025
@harshit-gangal harshit-gangal marked this pull request as ready for review February 11, 2025 08:20
@harshit-gangal
Copy link
Member Author

Website Doc PR: vitessio/website#1935

@deepthi
Copy link
Member

deepthi commented Feb 12, 2025

I understand that we can't re-use QueriesProcessed and QueriesRouted, because that might break people's dashboards, but we need to come up with some other names for QueryProcessed and QueryRouted which are grammatical. Leaving this comment as a place-holder while I try to think of alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants