Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Unify VReplication and VTGate VStream Retry Logic #17783

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Feb 13, 2025

Description

In VTGate VStreams, we've been returning errors to the client in various cases where a retry is likely to succeed. The most egregious example is the query interrupted MySQL error (see issue) that we expect to get from each tablet during the copy phase — when multiple copy phase cycles are required — every vreplication_copy_phase_duration. We expect that for large tables in Vitess v19.0 and later after the work done in #13840 .

This PR addresses this case and a variety of others by leveraging some of the same retry logic that we use for vreplication streams.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Feb 13, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 13, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 13, 2025
@mattlord mattlord changed the title VReplication: Unify vreplication and vtgate vstream retry logic VReplication: Unify VReplication and VTGate VStream Retry Logic Feb 13, 2025
@mattlord mattlord removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 13, 2025
@mattlord mattlord force-pushed the vstream_manager_retries branch 2 times, most recently from 47ef9af to b031939 Compare February 13, 2025 22:48
@mattlord mattlord force-pushed the vstream_manager_retries branch from b031939 to 8f31754 Compare February 13, 2025 22:53
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.96%. Comparing base (000fbbe) to head (fd73c53).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17783      +/-   ##
==========================================
+ Coverage   67.95%   67.96%   +0.01%     
==========================================
  Files        1586     1586              
  Lines      255208   255218      +10     
==========================================
+ Hits       173423   173468      +45     
+ Misses      81785    81750      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord mattlord force-pushed the vstream_manager_retries branch 2 times, most recently from 6f2a0cc to dc93152 Compare February 13, 2025 23:56
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the vstream_manager_retries branch from dc93152 to 4ef0558 Compare February 13, 2025 23:57
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Feb 14, 2025
@mattlord mattlord marked this pull request as ready for review February 14, 2025 01:01
@mattlord mattlord requested review from notfelineit and removed request for systay, timvaillancourt and harshit-gangal February 14, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: VTGate VStream API Does not Properly Handle Multiple Copy Phase Cycles
1 participant