-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Unify VReplication and VTGate VStream Retry Logic #17783
Open
mattlord
wants to merge
5
commits into
vitessio:main
Choose a base branch
from
planetscale:vstream_manager_retries
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
47ef9af
to
b031939
Compare
Signed-off-by: Matt Lord <[email protected]>
b031939
to
8f31754
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17783 +/- ##
==========================================
+ Coverage 67.95% 67.96% +0.01%
==========================================
Files 1586 1586
Lines 255208 255218 +10
==========================================
+ Hits 173423 173468 +45
+ Misses 81785 81750 -35 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matt Lord <[email protected]>
6f2a0cc
to
dc93152
Compare
Signed-off-by: Matt Lord <[email protected]>
dc93152
to
4ef0558
Compare
Signed-off-by: Matt Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In VTGate VStreams, we've been returning errors to the client in various cases where a retry is likely to succeed. The most egregious example is the query interrupted MySQL error (see issue) that we expect to get from each tablet during the copy phase — when multiple copy phase cycles are required — every
vreplication_copy_phase_duration
. We expect that for large tables in Vitess v19.0 and later after the work done in #13840 .This PR addresses this case and a variety of others by leveraging some of the same retry logic that we use for vreplication streams.
Related Issue(s)
Checklist