-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow distrubited Tx commit and rollback when explicitly allowed #17787
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Roderick Yao <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17787 +/- ##
==========================================
+ Coverage 67.95% 67.97% +0.02%
==========================================
Files 1586 1586
Lines 255208 255208
==========================================
+ Hits 173423 173479 +56
+ Misses 81785 81729 -56 ☔ View full report in Codecov by Sentry. |
@mattlord I saw you leave the label of NeedWebsiteDocUpdate. I don't find any documents about the vitessdriver. Do you have any particular in mind? |
I wasn't sure if we would want to add any new docs or not so I left that decision to the reviewers. |
Description
This PR is for the Vitess Driver to allow COMMIT and ROLLBACK of a distributed transaction from a non-original connection/session. The use case is described in this feature request #17786 .
Related Issue(s)
Fixes #17786
Checklist