vtorc
: remove duplicate instance read from backend
#17834
+2
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents a duplicate read of an instance in
inst.ReadTopologyInstanceBufferable(...)
, which is a pretty hot-path funcImmediately before
fullStatus(...)
is called we callinst.ReadTablet(...)
and todayfullStatus(...)
immediately does the sameinst.ReadTablet(...)
read againRelated Issue(s)
#17330
Checklist
Deployment Notes