Lucene & Special Characters #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue with this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basics tests demonstrating the current behavior of Lucene retrieval with special characters. The use case would be "-" in an OCR string.
The reason it fails is that cottontail is unable to handle special characters consistently.
There are open questions on if and how cottontail should expect those to be escaped, which i don't have particularly strong opinions on.
I think it would be helpful to have test which demonstrate and verify the kinds of input cottontail can handle, so feel free to change any of the tests.
Additionally, some of the random-generation code did not compile, so i adjusted the method calls to more basic, but equivalent ones.