Performance#257
Closed
AnAvailableName wants to merge 2 commits into
Closed
Conversation
Member
|
I like the simplification of the code, but I'm not sure whether performance is actually affected by this. First, performance on this level is not that crucial for the project, and second, we don't track performance in our CI, so we would have to do systematic measurements to even assess the performance impact of these changes. All in all, I think, I would frame the changes as code simplification instead. |
AnAvailableName
force-pushed
the
performance
branch
from
8a2ecb4 to
87e9899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Levarage Java API to simplify the code.