Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add downloadUrl for derives #1290

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Prev Previous commit
Next Next commit
PEP8
ArneGudermann committed Oct 21, 2024
commit 0c5f8674f828c8395a66886c6294326efccdb184
9 changes: 4 additions & 5 deletions src/viur/core/render/json/default.py
Original file line number Diff line number Diff line change
@@ -158,14 +158,13 @@ def renderSkelValues(self,
expires=conf.render_json_download_url_expiration
)


# generate the downloadUrl for derives
search_paths= []
search_paths = []
if search_path := current.request.get().request.headers.get("X-VIUR-DERIVED-DOWNLOAD-URL"):
search_paths.append(search_path)
if conf.file_generate_download_url_for_derives:

if isinstance(conf.file_generate_download_url_for_derives,list):
if isinstance(conf.file_generate_download_url_for_derives, list):
search_paths.extend(conf.file_generate_download_url_for_derives)
else:
search_path.append("*")
@@ -176,8 +175,8 @@ def renderSkelValues(self,
else:
return res

for derive_name in res.get("derived",{}).get("files",{}):
res["derived"]["files"][derive_name]["downloadUrl"]=File.create_download_url(
for derive_name in res.get("derived", {}).get("files", {}):
res["derived"]["files"][derive_name]["downloadUrl"] = File.create_download_url(
skel["dlkey"],
derive_name,
derived=True