Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure derives are generated in FileBone inside a RecordBone too #1370

Merged
merged 4 commits into from
Jan 19, 2025
Merged

fix: Ensure derives are generated in FileBone inside a RecordBone too #1370

merged 4 commits into from
Jan 19, 2025

Conversation

sveneberth
Copy link
Member

@sveneberth sveneberth commented Jan 15, 2025 •
edited
Loading

The postSavedHandler of the FileBone inside a RelSkel (which is used as UsingSkel for a RecordBone) was never called. Therefore ensureDerived was never called for this bone too and derives are never generated.

Fixes #817

@sveneberth sveneberth changed the base branch from main to 3.6 January 15, 2025 00:12
@sveneberth sveneberth added bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Jan 15, 2025
@sveneberth sveneberth marked this pull request as ready for review January 15, 2025 00:24
@phorward phorward merged commit a090e5b into viur-framework:3.6 Jan 19, 2025
4 checks passed
@sveneberth sveneberth deleted the fix/derive_in_recordbone branch January 20, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@ArneGudermann ArneGudermann Awaiting requested review from ArneGudermann

Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
Documentation
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derives for FileBones not working in RelSkels
2 participants
@sveneberth @phorward