feat: Evaluate x-viur-bonelist on default viewSkel()
#1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveneberth
reviewed
Jan 24, 2025
sveneberth
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Now we have a header that controls a bonelist. The header is evaluated by default for all viewSkels.
But what happens if I load another skeleton within the same request? Then the same bonelist is also used for the other skel. You don't want that ...
Furthermore, the Vary header should be set in the response after (and if) the bonelist has been evaluated and applied.
sveneberth
requested changes
Jan 27, 2025
- Introduces generic `SkelModule.skel()` function to obtain a skeleton instance. - Modifies all prototypes to accept `bones_from_request` Replacement for viur-framework#1376
phorward
force-pushed
the
feat-x-viur-bonelist
branch
from
7ec55ae to
32399e2
Compare
akelch
previously approved these changes
Feb 5, 2025
phorward
added
Priority: High
- faces some review issues of @sveneberth - no satisfying integration with existing code
phorward
added a commit
to phorward/viur-core
that referenced
this pull request
Feb 17, 2025
This is a lighter version of viur-framework#1384, integrating the feature only for `Singleton` and `List`.
phorward
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkelModule.skel()function to obtain a skeleton instance.bones_from_requestReplacement for #1376