-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RebuildSearchIndex
also with a specific key
#1403
Open
phorward
wants to merge
6
commits into
viur-framework:main
Choose a base branch
from
phorward:feat-RebuildSearchIndex-with-specific_key
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: RebuildSearchIndex
also with a specific key
#1403
phorward
wants to merge
6
commits into
viur-framework:main
from
phorward:feat-RebuildSearchIndex-with-specific_key
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactoring and improvement of the RebuildSearchIndex task. Sometimes it is necessary to refresh a single entry with a specific key, especially because the `refresh()`-logic is being used. Instead of adding a new task for this, this pull requests adds the ability to either update all kinds, all entries of a specific kind or a single entry with a given key. This PR also refactors the naming, because "kindnames" where referred as "modules" before.
ArneGudermann
requested changes
Feb 5, 2025
I don't wanna except on google.protobuf.message.DecodeError, which is raised particularly.
RebuildSearchIndex
with a specific keyRebuildSearchIndex
also with a specific key
sveneberth
requested changes
Feb 5, 2025
sveneberth
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Co-authored-by: Sven Eberth <[email protected]>
…m:phorward/viur-core into feat-RebuildSearchIndex-with-specific_key
1e12a6b
to
d67862a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature or request
main
Priority: Medium
This issue may be useful, and needs some attention.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring and improvement of the RebuildSearchIndex task.
Sometimes it is necessary to refresh a single entry with a specific key, especially because the
refresh()
-logic is being used. Instead of adding a new task for this, this pull requests adds the ability to either update all kinds, all entries of a specific kind or a single entry with a given key.This PR also refactors the naming, because "kindnames" where referred as "modules" before.