Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for pep8speaks to enforce PEP-8-compliant pull request #504

Merged
merged 4 commits into from
Oct 29, 2022

Conversation

Grashalmbeisser
Copy link
Contributor

Wrote an .pep8speaks.ylm for the github action https://github.com/OrkoHunter/pep8speaks.

This will allow us to get comments of the pep8 conformance of our future pull requests

@phorward
Copy link
Member

phorward commented Sep 9, 2022

Hello @Grashalmbeisser, thanks for starting this heavy task of making VIUR PEP8-conform.
This pull requests is linked to #448.

Wrote an .pep8speaks.ylm for the github action https://github.com/OrkoHunter/pep8speaks.

Why isn't the pep8speaks github action part of this pull request?

@sveneberth sveneberth added the feature New feature or request label Sep 9, 2022
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @phorward I think the gh-actions workflow is missing.

And we should add a script and the dependencies to the Pipfile for local testing/linting. And maybe a git pre-commit hook setup script?

max-line-length now set to 120 characters
Copy link
Member

@phorward phorward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out the comment. Is the pull request then finished?

@sveneberth
Copy link
Member

Please check out the comment. Is the pull request then finished?

I still miss the changes mentioned in my comment.🫤

Co-authored-by: Jan Max Meyer <[email protected]>
@phorward
Copy link
Member

Still, the GitHub Action is missing. Can you please integrate that, @Grashalmbeisser? I really want this feature available with v3.3 so new pull requests are being checked for PEP-8 compliance.

@phorward phorward added ci/cd and removed feature New feature or request labels Oct 26, 2022
@Grashalmbeisser
Copy link
Contributor Author

pep8speaks is a GitHub marketplace app and can be installed for the whole project.
Therefore it runs on Git itself and just needs to be installed via the marketplace for the Project.
The PRed pep8speaks.yml is only for the further configuration of the app.

@phorward phorward changed the title pep8 checker Add configuration for pep8speaks to enforce PEP-8-compliant pull request Oct 29, 2022
@phorward phorward merged commit 886766c into viur-framework:develop Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants