-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for pep8speaks to enforce PEP-8-compliant pull request #504
Conversation
Hello @Grashalmbeisser, thanks for starting this heavy task of making VIUR PEP8-conform.
Why isn't the pep8speaks github action part of this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like @phorward I think the gh-actions workflow is missing.
And we should add a script and the dependencies to the Pipfile for local testing/linting. And maybe a git pre-commit hook setup script?
max-line-length now set to 120 characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check out the comment. Is the pull request then finished?
I still miss the changes mentioned in my comment.🫤 |
Co-authored-by: Jan Max Meyer <[email protected]>
Still, the GitHub Action is missing. Can you please integrate that, @Grashalmbeisser? I really want this feature available with v3.3 so new pull requests are being checked for PEP-8 compliance. |
pep8speaks is a GitHub marketplace app and can be installed for the whole project. |
Wrote an .pep8speaks.ylm for the github action https://github.com/OrkoHunter/pep8speaks.
This will allow us to get comments of the pep8 conformance of our future pull requests