Accept variations parameters with bool type hints #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIUR currently allows only to pass True, yes or 1 as valid strings when a bool type hint is accepted. This is confusing, especially when true is provided, which is the valid true keyword for boolean true in the javascript word (and also many other, more professional programming languages than Python...)
sveneberth
requested changes
Oct 25, 2022
Removing "jawoll, herr oberleutnant" and swapping strip before lower.
sveneberth
requested changes
Oct 26, 2022
phorward
added
the
refactoring
|
In this context we should add the same behavior in the viur-core/core/bones/boolean.py Line 46 in 198478b |
sveneberth
requested changes
Nov 2, 2022
sveneberth
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIUR currently allows only to pass True, yes or 1 as valid strings when a bool type hint is accepted. This is confusing, especially when true is provided, which is the valid true keyword for boolean true in the javascript word (and also many other, more professional programming languages than Python...)