Open
Conversation
…oth binary and non-binary data.
…moved from the keys set.
Python3 support
Hashlib requires that any string passed to the md5 hash function be properly encoded beforehand. This patch does that, fixing the "TypeError: Unicode-objects must be encoded before hashing" that arises currently when decorating a function with @cache_it_json().
Redis4 support
Encode function arguments before hashing them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea how to report this since it's not an issue in the original repo, it's a problem in the fork that I'm opening the PR from. I got the package from PyPI and got this error
N.B. YashSinha1996's PR doesn't have this issue