Sort variants by bandwidth ascending to align with hls.js behavior#34
Open
mikeharty wants to merge 5 commits intovivictorg:masterfrom
Open
Sort variants by bandwidth ascending to align with hls.js behavior#34mikeharty wants to merge 5 commits intovivictorg:masterfrom
mikeharty wants to merge 5 commits intovivictorg:masterfrom
Conversation
Author
|
I ended up flipping this - the rest of the code expects the player to start with the "first" variant in the list, which when sorting in ascending order is the lowest quality variant - not a great default behavior. I updated it to sort on bitrate descending, and then invert the index when setting it in HLS.js. |
added 3 commits
September 13, 2024 19:20
Fix play button arrow alignment Add check for global leftVideoUrl and rightVideoUrl variables Fix HLS variant selection immediately after load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variant list in the UI has the variants in the order that they appear in the manifest, but HLS.js is sorting them by bitrate in ascending order - this means that the variant changing mechanism potentially switches to a different variant than the one the user selected (unless the manifest is ordered that way already, which it often is). This sorts the the list in the same way.