Skip to content

Commit

Permalink
Merge pull request #308 from vivliostyle/fix/web-firebase-signin
Browse files Browse the repository at this point in the history
fix: Use signInWithPopup() instead of signInWithRedirect() for Firebase sign-in
  • Loading branch information
MurakamiShinyu authored Jun 20, 2024
2 parents c18d30f + c77a68d commit 78f8694
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions web/src/middlewares/contexts/useAppContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
onAuthStateChanged,
User,
getAuth,
signInWithRedirect,
signInWithPopup,
GithubAuthProvider,
} from '@firebase/auth';
import * as UI from '@components/ui';
Expand Down Expand Up @@ -262,7 +262,7 @@ export function AppContextProvider({children}: {children: JSX.Element}) {
*/
const signIn = useCallback(() => {
const auth = getAuth(firebase);
signInWithRedirect(auth, provider);
signInWithPopup(auth, provider);
}, []);
/**
* サインアウト
Expand Down

0 comments on commit 78f8694

Please sign in to comment.