JS dependencies updates #4065
Merged
JS dependencies updates #4065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
Apr 3, 2025
webapp/src/main/webapp/templates/freemarker/edit/forms/js/manageHideShowStatus.js
Show resolved
Hide resolved
chenejac
reviewed
Apr 30, 2025
webapp/src/main/webapp/templates/freemarker/edit/forms/js/manageWebpagesForIndividual.js
Outdated
Show resolved
Hide resolved
chenejac
reviewed
Jun 3, 2025
There was a problem hiding this comment.
@litvinovg The code looks good. I have tested the PR branch:
- Landing pages for individuals have a warning about deprecated feature of tiny mce javascript
- Capability map and collaboration network - a warning about deprecated feature for jquery
- Also, I found for adding an author and editor to document an issue with label with non existing id used by for attribute, but it is not linked with this PR
Please, check whether the first two issues should be resolved in this PR.
Removed not used files, minor fixes
|
Rebased on top of main branch to resolve merge conflicts. |
I fixed more deprecated jquery calls. Please have a look. |
brianjlowe
approved these changes
Jun 9, 2025
chenejac
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
Vitro PR
What does this pull request do?
This PR updates links to some js dependencies:
jquery to version 3.7.1
jquery-ui to version 1.13.2
jquery-migrate to version 3.4.1
dataTables to version 2.2.2
Removes not used anymore js, css files
How should this be tested?
Browse following pages:
Additional Notes:
Based on Benjamin Gross work vivo-project/Vitro#449
Interested parties
@VIVO-project/vivo-committers
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed