[v0.19.1rc1] fix(npu): preserve AFD DBO config during auto worker selection - #190
Closed
jiaran-king wants to merge 1 commit into
Closed
[v0.19.1rc1] fix(npu): preserve AFD DBO config during auto worker selection#190jiaran-king wants to merge 1 commit into
jiaran-king wants to merge 1 commit into
Conversation
jiaran-king
marked this pull request as ready for review
August 3, 2026 10:04
jiaran-king
requested review from
hsliuustc0106 and
jiangkuaixue123
as code owners
August 3, 2026 10:04
Collaborator
Author
|
@yujuancao07, this |
Signed-off-by: zzh <jiaranran2@gmail.com>
jiaran-king
force-pushed
the
codex/issue188-release-v0191rc1
branch
from
August 3, 2026 10:39
bf7a525 to
3fde850
Compare
Collaborator
|
Please add test result. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the
release/v0.19.1rc1backport of the same focused Issue #188 fix proposed in #189.release/v0.19.1rc1@921ef6fc725011b4662ed2c3f4eb6942df1f211550a42b73083a54294c34751905b74a3c3de6302d3fde850Root cause and fix
With AFD NPU DBO enabled and
worker_cls="auto", vLLM-Ascend v0.19.1rc1 rewrites the temporary validation backend fromdeepep_low_latencytoflashinfer_all2allv. vLLM 0.19.1 then rejects that backend during native DBO validation before the AFD worker can be created.The backport:
NPUPlatform.check_and_update_confignormalization passenable_dbo,ubatch_size, andall2all_backendinfinallyVllmConfig.__post_init__()validation safeUsers should continue to omit
--worker-cls. Explicit Attention/FFN workers remain a compatibility path, not a requirement. Validation temporarily usesdeepep_low_latency; the existing worker initialization helper keeps the actual Ascend runtime backend atflashinfer_all2allv.Validation on the release base
Environment: macOS arm64, Python 3.12.13. The release checkout was installed editable without runtime dependencies for CPU-safe tests.
python -m pytest -q tests/unit/compat/patches/test_config_validation.py tests/unit/compat/test_runtime.pypython -m pytest tests/unit -o addopts=python -m ruff check .python -m ruff format --check .git diff --check upstream/release/v0.19.1rc1..HEADThe regression suite models the actual platform ordering and covers Attention/FFN automatic workers, DBO state preservation, repeated validation, exception restoration, explicit workers, non-AFD NPU behavior, DBO off, GPU behavior, 310P/Xlite restrictions, runtime backend selection, and ImportError retry.
Real NPU validation pending
This task did not access an NPU server or run hardware E2E. External validation should confirm:
--worker-clson either roleflashinfer_all2allvDBO assertion during startup/v1/modelsand completion requests succeedflashinfer_all2allvNo DBO performance or throughput claim is made.
Related to #188 and #189. This PR must not close Issue #188 by itself.