Skip to content

fix: preserve parallel tool call setting#126

Closed
harivilasp wants to merge 1 commit into
vllm-project:mainfrom
harivilasp:agent/nonduplicate-tested-fix
Closed

fix: preserve parallel tool call setting#126
harivilasp wants to merge 1 commit into
vllm-project:mainfrom
harivilasp:agent/nonduplicate-tested-fix

Conversation

@harivilasp

@harivilasp harivilasp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • parse parallel_tool_calls on /v1/responses requests
  • forward the field through RequestPayload::to_upstream_request after gateway tool normalization
  • add unit and route-level regression coverage proving parallel_tool_calls: false reaches the mock vLLM request

Closes #127.

Why

The gateway already preserves several Responses API generation/control fields (include, temperature, top_p, max_output_tokens, truncation, metadata) while normalizing tools for vLLM. parallel_tool_calls was missing from the typed request model, so clients that explicitly disabled parallel tool calls had that setting silently dropped on the executor path.

Validation

  • cargo test -p agentic-server-core
  • cargo test -p agentic-server --test responses_test
  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo fmt -- --check

Focused tests were written first and failed before the implementation because parallel_tool_calls serialized as absent/null instead of false.

Signed-off-by: harivilasp <harivilasp@gmail.com>
@harivilasp harivilasp force-pushed the agent/nonduplicate-tested-fix branch from ab500cf to 51eabd9 Compare July 16, 2026 00:11
@harivilasp harivilasp marked this pull request as ready for review July 16, 2026 00:15
@harivilasp harivilasp closed this Jul 16, 2026
@harivilasp harivilasp deleted the agent/nonduplicate-tested-fix branch July 16, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve parallel_tool_calls in Responses gateway requests

1 participant