fix: preserve parallel tool call setting#126
Closed
harivilasp wants to merge 1 commit into
Closed
Conversation
Signed-off-by: harivilasp <harivilasp@gmail.com>
ab500cf to
51eabd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parallel_tool_callson/v1/responsesrequestsRequestPayload::to_upstream_requestafter gateway tool normalizationparallel_tool_calls: falsereaches the mock vLLM requestCloses #127.
Why
The gateway already preserves several Responses API generation/control fields (
include,temperature,top_p,max_output_tokens,truncation,metadata) while normalizing tools for vLLM.parallel_tool_callswas missing from the typed request model, so clients that explicitly disabled parallel tool calls had that setting silently dropped on the executor path.Validation
cargo test -p agentic-server-corecargo test -p agentic-server --test responses_testcargo test --workspacecargo clippy --workspace --all-targets -- -D warningscargo fmt -- --checkFocused tests were written first and failed before the implementation because
parallel_tool_callsserialized as absent/null instead offalse.