Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ all = { level = "deny", priority = -1 }
pedantic = { level = "warn", priority = -1 }

[workspace.dependencies]
agentic-core = { path = "crates/agentic-core" }
agentic-core = { package = "agentic-server-core", path = "crates/agentic-server-core", version = "0.1.0" }

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description says 0.0.1 (workspace version + this pin), but it's 0.1.0 here and the workspace version at line 6 is unchanged too — the diff doesn't bump anything. Which one's intended for the release? Worth pinning down since crates.io versions are immutable once published.

Minor while you're here: the packaged tarball still ships tests/ and benches/ sources but excludes their cassette fixtures, so cargo test from the published crate can't find them. Harmless for consumers, but excluding tests/** + benches/** too would slim it if you want.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops this was a miss, fixed.

async-stream = "0.3"
axum = { version = "0.8", features = ["ws"] }
either = "1"
Expand Down
1 change: 1 addition & 0 deletions crates/agentic-praxis/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version.workspace = true
edition.workspace = true
license.workspace = true
repository.workspace = true
publish = false

[dependencies]
agentic-core.workspace = true
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
[package]
name = "agentic-core"
name = "agentic-server-core"
description = "Framework-agnostic core library for agentic-api"
version.workspace = true
edition.workspace = true
license.workspace = true
repository.workspace = true
exclude = [
"agentic_api.db*",
"benches/**",
"tests/**",
]

[lib]
name = "agentic_core"

[dependencies]
async-stream.workspace = true
Expand Down
64 changes: 32 additions & 32 deletions docs/adr/ADR-03_gateway_integration.md

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions docs/design/core-public-api.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Design: `agentic-core` Public API
# Design: `agentic-server-core` Public API

> Status: Active — implementation in progress
> References: [ADR-03](../adr/ADR-03_gateway_integration.md), [Issue #42](https://github.com/vllm-project/agentic-api/issues/42), [Praxis #354](https://github.com/praxis-proxy/praxis/issues/354)
Expand Down Expand Up @@ -42,12 +42,12 @@ Each phase = one PR with tests. Phases are ordered by dependency.

### Phase 1: SSE Event Normalizer Module (lands on main — no PR #46 dependency)

**PR scope:** New `events/` module in `agentic-core` — separate from executor, no dependency on PR #46.
**PR scope:** New `events/` module in `agentic-server-core` — separate from executor, no dependency on PR #46.

Per @maralbahari's feedback ([PR #46 discussion](https://github.com/vllm-project/agentic-api/pull/46#discussion_r3352104210)): the SSE event handling should be a **separate core module** to avoid bloating the accumulator. Design draws from PydanticAI's `StreamedResponse._process_event()`.

```
crates/agentic-core/src/
crates/agentic-server-core/src/
events/
mod.rs // pub mod normalize; pub mod types;
types.rs // SSEEventType (28+ variants) + typed EventPayload enum
Expand Down
2 changes: 1 addition & 1 deletion docs/design/mcp-gateway-integration.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# MCP Gateway Integration

Target: `crates/agentic-core/`
Target: `crates/agentic-server-core/`
Reference: [mcp handlers](https://github.com/openai/codex/tree/main/codex-rs/core/src/tools/handlers), [rmcp-client](https://github.com/openai/codex/tree/main/codex-rs/rmcp-client), [turn.rs](https://github.com/openai/codex/blob/main/codex-rs/core/src/session/turn.rs), [rust-sdk README](https://github.com/modelcontextprotocol/rust-sdk#readme)

---
Expand Down