Scheduler refactor: base/main PR for final merge #286
+4,102
−298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markurtz
changed the title
…singleton (#289) ## Summary This PR introduces four new utility modules that provide foundational capabilities for auto-discovery, registry patterns, singleton management, and enhanced Pydantic utilities. It additionally consolidates the pydantic utility classes from guidellm.objects into the dedicated guidellm.utils module containing the new additions. This change improves code organization and establishes the foundation for upcoming scheduler refactoring work. ## Details - **Moved core utilities** from `guidellm.objects.pydantic` to `guidellm.utils.pydantic_utils` - **Added `AutoImporterMixin`** for dynamic module discovery within packages - **Added `RegistryMixin`** for object registration with optional auto-discovery - **Added singleton mixins** (`SingletonMixin`, `ThreadSafeSingletonMixin`) for instance management - **Enhanced Pydantic utilities** with `ReloadableBaseModel`, `StandardBaseDict`, and `PydanticClassRegistryMixin` for polymorphic model serialization - **Updated all imports** across the codebase to reference new module locations - **Added comprehensive test coverage** for all new utility modules - **Removed obsolete** `guidellm.objects.pydantic` module and associated tests ## Test Plan - Run existing test suite to ensure no regressions from import changes - Execute new utility module test suites covering smoke, sanity, and regression scenarios ## Related Issues --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [x] Includes AI-assisted code completion - [x] Includes code generated by an AI application - [ ] Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes `## WRITTEN BY AI ##`) --------- Signed-off-by: Mark Kurtz <[email protected]> Co-authored-by: Copilot <[email protected]>
## Summary
This PR adds new utility modules for safe math function operations,
object info extraction, and reorganizes to consolidate into the utils
package.
## Details
- **Move statistics classes from `objects` to `utils`**:
Relocates `DistributionSummary`, `Percentiles`, `RunningStats`, `StatusDistributionSummary`,
and `TimeRunningStats` from `guidellm.objects.statistics` to `guidellm.utils.statistics`
- **Add new `functions.py` module**: Implements defensive programming
utilities
including `safe_getattr`, `safe_divide`, `safe_multiply`, `safe_add`, `safe_format_timestamp`,
and `all_defined` for handling None values and edge cases
- **Add new `mixins.py` module**: Provides `InfoMixin` class for
standardized metadata extraction and object introspection across
different class hierarchies
- **Enhance `text.py` module**: Adds comprehensive
documentation, `format_value_display` function for consistent metric
formatting, and improved text processing utilities
- **Update import statements**: Modifies all affected modules
(`benchmark`, `presentation`) to import statistics classes from their
new location in `utils`
- **Remove deprecated `objects` package**: Deletes the
now-empty `objects` directory and associated test files
- **Add comprehensive test coverage**: Includes new test suites
for `functions.py`, `mixins.py`, and `statistics.py`
- **Update `__init__.py` exports**: Adds new utility functions and
classes to the main utils package exports for easy access
## Test Plan
- Run the existing test suite to ensure no regressions from the
statistics class relocation
- Execute new test files:
- test_functions.py - Tests for safe operation utilities
- test_mixins.py - Tests for InfoMixin functionality
- test_statistics.py - Comprehensive tests for statistical analysis
utilities
- test_text.py - Tests for enhanced text processing functions
## Related Issues
- Resolves #
---
- [X] "I certify that all code in this PR is my own, except as noted
below."
## Use of AI
- [X] Includes AI-assisted code completion
- [X] Includes code generated by an AI application
- [ ] Includes AI-generated tests (NOTE: AI written tests should have a
docstring that includes `## WRITTEN BY AI ##`)
---------
Signed-off-by: Mark Kurtz <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Samuel Monson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main PR for the scheduler refactor project that all other PRs will be opened off of for review to limit PR sizes and consolidate into a central location for landing on main at once. Once all PRs are merged for the scope of the work, this will be merged into main.
The scheduler refactor is targeted at enhancing GuideLLM across a number of different targeted features and performance fixes. It rebuilds the core behind GuideLLM from the ground up with both performance and flexibility in mind. The specific features and fixes added with this refactor are the following:
Details
Contained PRs and pending work:
Test Plan
Related Issues
Use of AI
## WRITTEN BY AI ##)