Skip to content

Conversation

@tukwila
Copy link
Contributor

@tukwila tukwila commented Nov 24, 2025

Summary

Details

  • [ ]

#479

Test Plan

Related Issues

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@tukwila
Copy link
Contributor Author

tukwila commented Nov 24, 2025

@sjmonson please check this issue and fix code. Thks.

@sjmonson
Copy link
Collaborator

sjmonson commented Nov 24, 2025

I am not sure what this fix is accomplishing. The check on line 106 already makes sure either the data or url key exists.

Edit: Ah ok I missed #479.

@sjmonson sjmonson added this to the v0.4.1 milestone Nov 24, 2025
Signed-off-by: guangli.bao <[email protected]>
@sjmonson sjmonson merged commit ce0ae7b into vllm-project:main Nov 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants