Refactor CLI into nested structure#717
Open
sjmonson wants to merge 1 commit intofeat/arg_parserfrom
Open
Conversation
Signed-off-by: Samuel Monson <smonson@redhat.com>
dbutenhof
approved these changes
May 5, 2026
Collaborator
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
It's hard to review this sort of refactoring without simply trusting that it's mostly a cut-and-paste; but that appears to be essentially the case, (and so I've avoided making some random commentary along the way that would equally apply to the current code) ... so I've really just got one minor comment comment...
| status="success", | ||
| ) | ||
| server.run() | ||
| """Entry points for guidellm.""" |
Collaborator
There was a problem hiding this comment.
OK, I would have stuck with the first line of the old comment: "GuideLLM command-line interface entry point".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates CLI code out of
__main__.pyand into its own submodule.Details
The PR is purely refactoring. Making this change now will make the incoming CLI refactor a little cleaner to review.
Test Plan
Run any existing CLI commands to confirm functionality.
Use of AI
## WRITTEN BY AI ##)