[ROCm] Document Kimi-K2.5 MXFP4 MI355X benchmark reproduction#673
Conversation
Add the InferenceX Kimi-K2.5 MXFP4 MI355X benchmark reproduction env vars and vLLM serve command. Signed-off-by: haic0 <haichzha@amd.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates the Kimi-K2.5.yaml model configuration file to include detailed instructions, environment variables, and a run command for reproducing the MXFP4 benchmark on the InferenceX MI355X platform. The review feedback recommends adding a default fallback value for the $MAX_MODEL_LEN environment variable in the reproduction command to prevent execution failures if the variable is not defined.
| --port "${PORT:-8000}" \ | ||
| --tensor-parallel-size 4 \ | ||
| --gpu-memory-utilization 0.85 \ | ||
| --max-model-len "$MAX_MODEL_LEN" \ |
There was a problem hiding this comment.
The environment variable $MAX_MODEL_LEN is not defined or exported in the preceding setup instructions. If a user copies and runs this command directly, the variable will evaluate to an empty string, which can cause the vLLM server to fail or behave unexpectedly. Providing a default fallback value like ${MAX_MODEL_LEN:-9472} ensures the command is robust and runnable out-of-the-box.
--max-model-len "${MAX_MODEL_LEN:-9472}" \| amd: | ||
| # Verified on 8× MI300X / MI355X (MI325X listed as supported but not verified). | ||
| extra_env: | ||
| VLLM_ROCM_USE_AITER: "1" |
There was a problem hiding this comment.
@haic0 @chunfangamd u gotta add ur extra envs here too or else the recipes production website doesnt show it in quick select
https://recipes.vllm.ai/moonshotai/Kimi-K2.5?hardware=mi355x&variant=mxfp4
Summary
Test plan
pythonYAML parse and top-level schema-order check formodels/moonshotai/Kimi-K2.5.yamlgit diff --check -- models/moonshotai/Kimi-K2.5.yamlnode scripts/build-recipes-api.mjs