Skip to content

[ROCm] Document Kimi-K2.5 MXFP4 MI355X benchmark reproduction#673

Merged
xianbaoqian merged 1 commit into
vllm-project:mainfrom
haic0:haic0/document-kimi-k25-mxfp4-mi355x-benchmark
Jul 23, 2026
Merged

[ROCm] Document Kimi-K2.5 MXFP4 MI355X benchmark reproduction#673
xianbaoqian merged 1 commit into
vllm-project:mainfrom
haic0:haic0/document-kimi-k25-mxfp4-mi355x-benchmark

Conversation

@haic0

@haic0 haic0 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a Kimi-K2.5 MXFP4 MI355X benchmark reproduction subsection based on SemiAnalysisAI/InferenceX PR #2213.
  • Replace the older fixed-sequence throughput note with the PR #2213 TP4, fp8 KV, scheduler, and AITER env settings.
  • Keep the default Kimi-K2.5 MXFP4 serving command unchanged; document the InferenceX lane as a separate high-concurrency benchmark configuration.

Test plan

  • python YAML parse and top-level schema-order check for models/moonshotai/Kimi-K2.5.yaml
  • git diff --check -- models/moonshotai/Kimi-K2.5.yaml
  • node scripts/build-recipes-api.mjs

Add the InferenceX Kimi-K2.5 MXFP4 MI355X benchmark reproduction env vars and vLLM serve command.

Signed-off-by: haic0 <haichzha@amd.com>
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Ready Ready Preview, Comment Jul 23, 2026 8:00am

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kimi-K2.5.yaml model configuration file to include detailed instructions, environment variables, and a run command for reproducing the MXFP4 benchmark on the InferenceX MI355X platform. The review feedback recommends adding a default fallback value for the $MAX_MODEL_LEN environment variable in the reproduction command to prevent execution failures if the variable is not defined.

--port "${PORT:-8000}" \
--tensor-parallel-size 4 \
--gpu-memory-utilization 0.85 \
--max-model-len "$MAX_MODEL_LEN" \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The environment variable $MAX_MODEL_LEN is not defined or exported in the preceding setup instructions. If a user copies and runs this command directly, the variable will evaluate to an empty string, which can cause the vLLM server to fail or behave unexpectedly. Providing a default fallback value like ${MAX_MODEL_LEN:-9472} ensures the command is robust and runnable out-of-the-box.

    --max-model-len "${MAX_MODEL_LEN:-9472}" \

@chunfangamd

Copy link
Copy Markdown
Contributor

amd:
# Verified on 8× MI300X / MI355X (MI325X listed as supported but not verified).
extra_env:
VLLM_ROCM_USE_AITER: "1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haic0 @chunfangamd u gotta add ur extra envs here too or else the recipes production website doesnt show it in quick select

https://recipes.vllm.ai/moonshotai/Kimi-K2.5?hardware=mi355x&variant=mxfp4

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants