[misc] Remove useless patch_logits #4252
Merged
+1
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a patch for apply_repetition_penalties that is no longer necessary due to a fix in torch-npu 2.7.1. The changes are correct and improve code maintainability by removing obsolete code. The removal of the patch file and its import is clean, and I see no issues with this change.
Signed-off-by: wangxiyuan <[email protected]>
wangxiyuan
force-pushed
the
remove_patch
branch
from
46e7b76 to
e77713c
Compare
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
wangxiyuan
added
ready
wangxiyuan
changed the title
Kurumi5210
pushed a commit
to lidenghui1110/vllm-ascend
that referenced
this pull request
Nov 26, 2025
Torch-npu 2.7.1 has fixed the device check bug. This patch can be removed now. - vLLM main: vllm-project/vllm@2918c1b Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Kurumi5210 <[email protected]>
845473182
pushed a commit
to 845473182/vllm-ascend
that referenced
this pull request
Nov 29, 2025
Torch-npu 2.7.1 has fixed the device check bug. This patch can be removed now. - vLLM main: vllm-project/vllm@2918c1b Signed-off-by: wangxiyuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch-npu 2.7.1 has fixed the device check bug. This patch can be removed now.