-
Notifications
You must be signed in to change notification settings - Fork 609
MTP support DeepSeekV3.2 #4263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MTP support DeepSeekV3.2 #4263
Conversation
Signed-off-by: ZYang6263 <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds MTP support for the DeepSeekV3.2 model by mapping it to the existing DeepSeekMTP implementation. The change is functionally correct. I have provided one comment regarding code duplication to improve long-term maintainability and prevent potential future bugs.
| "DeepseekV32ForCausalLM": | ||
| ("vllm.model_executor.models.deepseek_mtp", "DeepSeekMTP"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MTP implementation for DeepseekV32ForCausalLM is identical to that of DeepseekV3ForCausalLM. This creates code duplication. To enhance maintainability and prevent potential bugs should the implementation path change in the future, it would be better to define this shared implementation path as a constant and reuse it for both model architectures.
For example:
DEEPSEEK_MTP_IMPL = ("vllm.model_executor.models.deepseek_mtp", "DeepSeekMTP")
_MTP_MODELS = {
"DeepseekV3ForCausalLM": DEEPSEEK_MTP_IMPL,
"DeepseekV32ForCausalLM": DEEPSEEK_MTP_IMPL,
"Qwen3NextForCausalLM":
("vllm_ascend.models.qwen3_next_mtp", "CustomQwen3NextMTP")
}
whx-sjtu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
Currently, MTP does not support the DeepSeekV3.2 model. In this PR, we have enabled this feature.
Does this PR introduce any user-facing change?
How was this patch tested?