-
Notifications
You must be signed in to change notification settings - Fork 176
[Build][0.7.3] Integrate MindIE Turbo into vLLM Ascend #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both below comments are addressed
docs/source/installation.md
Outdated
wget https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.0.0/Ascend-cann-toolkit_8.0.0_linux-aarch64.run | ||
chmod +x ./Ascend-cann-toolkit_8.0.0_linux-aarch64.run | ||
./Ascend-cann-toolkit_8.0.0_linux-aarch64.run --full | ||
wget https://ascend-repo.obs.cn-east-2.myhuaweicloud.com/CANN/CANN%208.1.RC1/Ascend-cann-toolkit_8.1.RC1_linux-"$(uname -i)".run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide takes aarch64 as an example. If you run on x86, you need to replace
aarch64
withx86_64
for the package name shown below.
The note can be removed
docs/source/installation.md
Outdated
```{code-block} bash | ||
:substitutions: | ||
|
||
pip install mindie_turbo==|pip_vllm_ascend_version| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be pip_mindie_turbo_version
4748a26
to
8ffa764
Compare
The ascend ci failed due to pull image time out, already synced this info to infra team |
84d352b
to
7406af5
Compare
Looks ready, the only thing we need to do is make sure mindie turbo integration doc works, wait mindie turbo release. Let's extract a new PR to upgrade the 8.1rc1 first: #746 |
### What this PR does / why we need it? Make CANN version bump separately from #708 - Upgrade CANN version to 8.1.rc1 - Add prefix to speed up download `m.daocloud.io/quay.io/ascend/cann:8.1.rc1-910b-ubuntu22.04-py3.10` - Address tail sapce for Dockerfile.openEuler - Add note for `/workspace` and `/vllm-workspace` as followup of #741 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? CI passed Co-authored-by: MengqingCao <[email protected]> Signed-off-by: Yikun Jiang <[email protected]> Co-authored-by: MengqingCao <[email protected]>
Co-authored-by: Yikun Jiang <[email protected]> Signed-off-by: MengqingCao <[email protected]>
a57f7e7
to
e012433
Compare
Signed-off-by: MengqingCao <[email protected]> Signed-off-by: Yikun Jiang <[email protected]>
) Integrate MindIE Turbo into vLLM Ascend: - Added support for MindIE Turbo in `setup.py` via an optional dependency under `extras_require`. - Enhanced `try_register_lib` utility to log specific exceptions when MindIE Turbo is not found. - Updated documentation to include instructions for installing MindIE Turbo: - Improved documentation with links to Bisheng compiler optimization tutorials and MindIE Turbo documentation. NO CI passed --------- Signed-off-by: MengqingCao <[email protected]> Signed-off-by: Yikun Jiang <[email protected]> Signed-off-by: hfadzxy <[email protected]>
What this PR does / why we need it?
Integrate MindIE Turbo into vLLM Ascend:
setup.py
via an optional dependency underextras_require
.try_register_lib
utility to log specific exceptions when MindIE Turbo is not found.Does this PR introduce any user-facing change?
NO
How was this patch tested?
CI passed