fix indents in model runner #722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed lines should be outside of bypass_model_exec
whx-sjtu
reviewed
Apr 29, 2025
| orig_model_forward_time)) | ||
| return hidden_or_intermediate_states | ||
| # TODO: remove the synchronize here | ||
| torch.npu.synchronize() |
There was a problem hiding this comment.
Can we remove the synchronize here now? CC @wangxiyuan
|
Thanks for the PR. But it's duplicated with this one: #658 Let's focus on 658, review it together to make it work as expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed lines should be outside of bypass_model_exec
What this PR does / why we need it?
This PR is intended to fix unexpected changes from #429. These unexpected changes will cause failure of PD disaggregation. Fall back them in this pr.
Does this PR introduce any user-facing change?
No
How was this patch tested?
should be tested with PD disaggregation.