Repository navigation
alerting: strike resolved alerts line-by-line, drop our '(edited)' suffix - #142
Merged
Merged
Conversation
…ffix Two rendering bugs from the live test: Slack mrkdwn strikethrough does not span line breaks (multi-line alerts showed literal tildes), and Slack appends its own '(edited)' marker to updated messages so ours duplicated it. The composed update is now ':white_check_mark: ' plus the original text with each line wrapped in ~...~. Signed-off-by: Thang Nguyen <thang.nguyen@inferact.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Two rendering bugs found in the live test of #141:
~…~does not span line breaks, so a multi-line alert showed literal tildes. Now each line is wrapped individually.(edited)— Slack appends its own(edited)marker to updated messages; ours was redundant. Dropped.Resulting edit:
:white_check_mark:+ the original alert with each line struck through — Slack adds(edited)itself.Tests
…shape and the absence of our own(edited)suffixpytest alerting202 passed, ruff cleanDeploy
Worker picks this up on the next
install.shfrommain.Signed-off-by: Thang Nguyen thang.nguyen@inferact.ai