-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[Frontend] refactor harmony utils output message parsing #29820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] refactor harmony utils output message parsing #29820
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the parse_output_message function in harmony_utils.py by extracting logic into several focused helper functions. The changes significantly improve code organization and maintainability. The refactoring is well-done, but I've identified a potential KeyError in the new _parse_browser_tool_call function due to an unsafe dictionary access. I've provided a suggestion to fix this. Apart from that, the changes look good.
f12b817 to
0b175cc
Compare
|
thanks for the review @qandrew @robertgshaw2-redhat @chaunceyjiang @yeqcharlotte please let me know if you have any feedback or if this good to approve/merge |
chaunceyjiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
cea3600 to
d8ebcb0
Compare
Signed-off-by: Daniel Salib <[email protected]>
d8ebcb0 to
354989a
Compare
…t#29820) Signed-off-by: Daniel Salib <[email protected]>
…t#29820) Signed-off-by: Daniel Salib <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
Purpose
Refactor parse_output_message() in harmony_utils.py to improve
code organization and maintainability by extracting parsing
logic into focused helper functions.
Changes
Split the monolithic parse_output_message() function into four
specialized helper functions:
(search, open, find)
content
Testing